Skip to content

compiler: set SourceURL in NEF file #4042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

compiler: set SourceURL in NEF file #4042

merged 1 commit into from
Oct 28, 2025

Conversation

@Turalchik
Copy link
Contributor

@Turalchik Turalchik commented Oct 20, 2025

Close #3543.

@Turalchik Turalchik force-pushed the add-sourceurl-to-nef branch from 79d446d to 3d351a9 Compare October 20, 2025 09:26
@codecov
Copy link

codecov bot commented Oct 20, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.36%. Comparing base (82f975e) to head (f0cdf1b).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4042      +/-   ##
==========================================
+ Coverage   72.65%   74.36%   +1.71%     
==========================================
  Files         364      364              
  Lines       56737    47589    -9148     
==========================================
- Hits        41222    35391    -5831     
+ Misses      13785    10467    -3318     
- Partials     1730     1731       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

AnnaShaleva
AnnaShaleva reviewed Oct 22, 2025
View reviewed changes
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks legit.

@Turalchik Turalchik force-pushed the add-sourceurl-to-nef branch 2 times, most recently from 6c50f45 to 70c9a68 Compare October 23, 2025 08:40
@Turalchik Turalchik requested a review from AnnaShaleva October 23, 2025 11:49
AnnaShaleva
AnnaShaleva reviewed Oct 24, 2025
View reviewed changes
compiler: set SourceURL in NEF file
f0cdf1b 
Close #3543.

Signed-off-by: Tural Devrishev <[email protected]>
@Turalchik Turalchik force-pushed the add-sourceurl-to-nef branch from 70c9a68 to f0cdf1b Compare October 27, 2025 10:07
@Turalchik Turalchik requested a review from AnnaShaleva October 27, 2025 10:09
AnnaShaleva
AnnaShaleva approved these changes Oct 28, 2025
View reviewed changes
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@AnnaShaleva AnnaShaleva merged commit e407d0f into master Oct 28, 2025
56 of 57 checks passed
@AnnaShaleva AnnaShaleva deleted the add-sourceurl-to-nef branch October 28, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

@AnnaShaleva AnnaShaleva AnnaShaleva approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

neotest.CompileFile does not add sourceURL to nef

4 participants

@Turalchik @roman-khimov @AnnaShaleva